Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let resharer to send an e-mail for public link #36393

Merged
merged 1 commit into from Nov 11, 2019
Merged

let resharer to send an e-mail for public link #36393

merged 1 commit into from Nov 11, 2019

Conversation

karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Nov 8, 2019 •
edited

Description

let resharer to send an e-mail for public link.

Related Issue

Motivation and Context

Currently, sending an e-mail when creating public links from received shares is impossible. This PR will fix this issue.

How Has This Been Tested?

Manually with issues scenario. Also, acceptance tests are ready.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@karakayasemi karakayasemi added this to the development milestone Nov 8, 2019
@karakayasemi karakayasemi self-assigned this Nov 8, 2019
@codecov
Copy link

codecov bot commented Nov 8, 2019 •
edited

Codecov Report

Merging #36393 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36393   +/-   ##
=========================================
  Coverage     64.87%   64.87%           
- Complexity    19797    19798    +1     
=========================================
  Files          1272     1272           
  Lines         74748    74748           
  Branches       1309     1309           
=========================================
  Hits          48495    48495           
  Misses        25867    25867           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.07% <100%> (ø) 19798 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/MailNotifications.php 96.64% <100%> (ø) 31 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26a76d...7a304fe. Read the comment docs.

phil-davis
phil-davis reviewed Nov 9, 2019
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Push a changelog entry here also.
I will look at adding some extra scenarios (issue #36388 ) that will cover a couple more combinations of this.

@karakayasemi
Copy link
Contributor Author

Changelog entry added.

@karakayasemi karakayasemi mentioned this pull request Nov 9, 2019
Closed
@karakayasemi
Copy link
Contributor Author

@phil-davis Should we wait for additional tests to merge?

@phil-davis
Copy link
Contributor

phil-davis commented Nov 11, 2019 •
edited

Don't wait. The scenario here demonstrates the fix. I can add more scenarios in another PR.
See issue #36388 and PR #36411

@phil-davis phil-davis merged commit 5503eb7 into master Nov 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-36386 branch November 11, 2019 08:38
This was referenced Nov 12, 2019
Closed
Closed
Merged
@micbar
Copy link
Contributor

micbar commented Nov 22, 2019

@karakayasemi I tried to demo it.
Had no luck!
Could not get this fix to work.

@karakayasemi
Copy link
Contributor Author

karakayasemi commented Nov 22, 2019 •
edited

@micbar I tested again, in my environment it is working as expected. We worked with BDD approach on this issue. There is an acceptance test scenario that simulates related scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@jvillafanez jvillafanez jvillafanez approved these changes

@VicDeo VicDeo Awaiting requested review from VicDeo

Assignees

@karakayasemi karakayasemi

Labels
3 - To Review
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.

Public links in shared folders do not work
4 participants
@karakayasemi @phil-davis @micbar @jvillafanez